Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jlink fails with openjdk(11|12|13) binaries for macOS: Error: Hash of java.rmi differs to expected hash recorded in java.base #1293

Closed
gubatron opened this issue Aug 21, 2019 · 2 comments
Labels
Milestone

Comments

@gubatron
Copy link

gubatron commented Aug 21, 2019

perhaps this issue will get a bit more attention here, more people involved in this repo.

jlink is broken on all macOS builds I've downloaded.

I've downloaded 3 different builds for macOS (x64/hotspot) (jdk11, jdk12, jdk13) and every time I try to create a custom jre with jlink I always have the following issue:

jlink --no-header-files --no-man-pages --add-modules --compress=1 java.base,java.compiler,java.desktop,java.instrument,java.management,jdk.management.agent,java.naming,java.prefs,java.scripting,java.sql,jdk.jdwp.agent,jdk.net,jdk.unsupported,jdk.security.auth,jdk.pack,jdk.crypto.cryptoki --output jre

Error: Hash of java.rmi (65cbca076e0ec4c90e2704d4fb8f4d7d121c0f0618a4af0381c9cc6aa58bc49c) differs to expected hash (e8e7adf5a12eba7ad5e980dfb857ab3ae770e4fce2a6cbffa83334d80436c38e) recorded in java.base

any help would be appreciated. I bet I'm not going to be the first ending up here given the Apple Store notarization requirements that don't pass with Oracle's JVM due to their .dylib files being built with an older MacSDK version. I was hoping AdoptOpenJDK uses newer MacSDK versions to build and finally be able to pass notarization without going down the rabbit hole of trying to build the JDK myself and risk incompatibility issues.

@smlambert
Copy link
Contributor

smlambert commented Aug 21, 2019

This is indeed a problem, our jlink tests failed, and the issue is related to code signing (a new step now required as part of building the binaries). We have reported the issue to the openjdk-build repo under this issue: adoptium/temurin-build#1214, so I will close this issue in the test repo, as the fix required is at the build repo.

The binaries are being rolled back, under AdoptOpenJDK/TSC#107 (linked here to let you know where to track the progress).

@karianna karianna added this to the August 2019 milestone Aug 21, 2019
@gubatron
Copy link
Author

Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants