Tweetest Prep for payara-mp-tck tests

[smlambert]

👾 Description of the issue

We run external third-party application tests at this project. They are contained within the external directory. We would like to improve how we run these tests. The first step to improving how we run them is to add some documentation and to pull out the individual test properties that we use so that they are stored in the same directory as the test.

This issue is to add a README.md and a test.properties file to the /external/payara-mp-tck test directory. As part of this prep work, since we already generate the Dockerfile, please also remove the static https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/payara-mp-tck/dockerfile/Dockerfile.

The contents of the README file can be simply some instructions for how to run the test locally. Use with the instructions from https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/README.md#running-external-tests-locally and modify Steps 7 and 9 to reference payara-mp-tck specifically.

The contents of the test.properties file will be a key=value format, copying the information from https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/common_functions.sh#L316-L328 to populate it.

Adding these files will not change the current way we run these tests. A separate change will be made to reference the test.properties file, at which point the contents must match those in the common_functions.sh script.

Please take the time to try and run the test locally (using the instructions you are adding in the README file). Some of the external tests are failing. When you run it locally, you may find that to be the case. The reviewer can help to advise you if there are any further steps you can take to try and debug the pre-existing failure, if it exists.

📋 Step by Step

To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here. Note: that you do not need to add yourself to a Contributors.md file as outlined in the detailed instructions.

• Claim this issue: Comment below.
• Fork the repository in github by simply clicking the 'fork' button.
• Check out the forked repository
• Create a feature branch for the issue. We do not have any naming definition for branches.
• Commit your changes.
• Start a Pull Request.
• Done 👍 Ask in comments for a review :)
• If the reviewer find some missing pieces or a problem they will start a discussion with you and describe the next steps how the problem can be solved.
• You did it 🎉 We will merge the fix in the master branch.
• Thanks, thanks, thanks for being part of this project as an open source contributor ❤️

🤔❓ Questions

If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

[benny-coy]

Good day @smlambert
I am an outreachy applicant. please can i work on this project?

[smlambert]

Most certainly, welcome @benny-coy, if you have questions please feel free to ask in this issue!

[benny-coy]

Thank you @smlambert .

[benny-coy]

@smlambert
Please, i need your help i am new here.
Please i have forked the repository to my GitHub account and clone it to my local machine.
I have opened the folder to this project locally. i also opened the README.md file. i saw some documentation.
My question is am i to delete it or modify it? as stated here.
The contents of the README file can be simply some instructions for how to run the test locally. Use with the instructions from "https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/external/README.md#running-external-tests-locally and modify Steps 7 and 9 to reference payara-mp-tck specifically." thank you.
I hope to get your reply soon.

[smlambert]

Please have a look at this PR as an example: https://github.com/AdoptOpenJDK/openjdk-tests/pull/2451/files

[benny-coy]

@smlambert thank you.

[benny-coy]

@smlambert
From what i copied i noticed that there might be a missing word here:
Running External tests locally
To run any AQA tests locally, you follow the same pattern:
0. Ensure your test machine is set up with test prereqs. For external tests, you do need Docker installed.

1. Download/unpack the SDK you want to (is there a missing word here?) your test machine
   If yes, please let me know the missing word?
   Thank you.

[smlambert]

1. Download/unpack the SDK* that you want to test to your test machine

*you can download binaries from adoptopenjdk.net

[benny-coy]

@smlambert
Please, is there anything I still have to do concerning this issue?

[smlambert]

Closed via #2480

For future reference, if you would have put Fixes #2480 in the comment of the PR, this issue would have been automatically closed when the PR was merged