Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new Tweetest Parameters with a fresh set of application repositories #2686

Closed
SAY-droid427 opened this issue Jun 29, 2021 · 8 comments
Closed
Labels
type:external 3rd party application tests (invoked by the make target 'external')

Comments

@SAY-droid427
Copy link
Contributor

No description provided.

@smlambert
Copy link
Contributor

As a starting point at #172 (we should go through others in the list to see if they are suitable for external_custom, but starting at zookeeper)

@smlambert smlambert added the type:external 3rd party application tests (invoked by the make target 'external') label Jul 2, 2021
@SAY-droid427
Copy link
Contributor Author

@smlambert Thank you for pointing out the test! Should I check whether the tests can be run using the changes in #2660?

@smlambert
Copy link
Contributor

smlambert commented Jul 2, 2021

Yes, and in fact what I was hoping is that we can get #2660 merged, so then we can run testing in Grinder_Tweetest, to save you from having to run locally. However, given many committers are out until Monday (so likely won't be merged until then), if you feel inspired please do so.

We should also review the remaining tests listed in #172 to see if others (in the list that are 'unchecked') are appropriate candidates for external_custom and could be added to this issues list for 'testing a fresh set'.

@SAY-droid427
Copy link
Contributor Author

Yes, and in fact what I was hoping is that we can get #2660 merged, so then we can run testing in Grinder_Tweetest, to save you from having to run locally. However, given many committers are out until Monday (so likely won't be merged until then), if you feel inspired please do so.

We should also review the remaining tests listed in #172 to see if others (in the list that are 'unchecked') are appropriate candidates for external_custom and could be added to this issues list for 'testing a fresh set'.

Thank you so much @smlambert ! I will try to run the test above and all those listed in the related issue list to check if they can be added to our eligible test lists :)

@SAY-droid427
Copy link
Contributor Author

SAY-droid427 commented Jul 5, 2021

TEST RESULTS FOR ZOOKEEPER with the following parameters set:
EXTERNAL_CUSTOM_REPO: https://github.com/apache/zookeeper
EXTERNAL_REPO_BRANCH: master
EXTERNAL_TEST_CMD: ant test

Results for make compile:
make_compile_zookeeper

Results for make _external_custom:
x
y

The BUILD was successful for make compile but not for make _external_custom. I hope make _external_custom is the correct command.
The same issue is with the other external tests like netty that I tested. The error message is coming from (external.sh)[https://github.com/adoptium/aqa-tests/blob/971950832563dc27d5e26e82fa894b0c5853b4df/external/external.sh#L127] but I did not recognise the changes I need to make to run make _external_custom.

@SAY-droid427
Copy link
Contributor Author

@smlambert I was running the tests and was wondering where could I find the EXTERNAL_TEST_CMD for each test?

@SAY-droid427
Copy link
Contributor Author

I am updating this doc with the list of all the tests with their required parameters for external_custom:
https://docs.google.com/document/d/1XBfUIhw6so6F1YCSiPEBVoMf-q4Pt_aMUSpvD2stS7o/edit?usp=sharing
This will be completed by tomorrow.

@smlambert
Copy link
Contributor

Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external 3rd party application tests (invoked by the make target 'external')
Projects
None yet
Development

No branches or pull requests

2 participants