Completed prep work for camel tests #2451

SAY-droid427 · 2021-04-01T15:17:26Z

Completed the prep work for camel tests

Removed static dockerfile
Added README.md
Added test.properties

SAY-droid427 · 2021-04-01T15:19:26Z

@smlambert Please review my PR for prep work for camel-tests. I have tried to do the task according to my understanding, but if anything was done wrong or anything needs to be changed, then please let me know and guide me. I will be happy to change it and learn more in the process.

smlambert

Looking pretty good! I have asked for a few updates before a 2nd review occurs.

smlambert · 2021-04-01T16:09:49Z

external/camel/README.md

@@ -0,0 +1,20 @@
+# External (Third Party Container) Tests


Please change the heading to:
External Camel Tests

smlambert · 2021-04-01T16:10:44Z

external/camel/README.md

+# External (Third Party Container) Tests
+Third Party container tests help verify that the AdoptOpenJDK binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests.
+
+## Running External tests locally


change to:
Running External Camel tests locally

smlambert · 2021-04-01T17:07:42Z

external/camel/README.md

+
+## Running External tests locally
+To run any AQA tests locally, you follow the same pattern:
+Ensure your test machine is set up with test prereqs. For external tests, you do need Docker installed.


Please restore all of the hyperlinks and special characters in this document so that </pathToWhereYouInstalledSDK> does not dissappear due to being rendered as html. For the test prereqs hyperlink, if you can link to https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/doc/Prerequisites.md (instead of the one at the openj9 project), , it will be great!

smlambert · 2021-04-01T17:11:47Z

external/camel/README.md

@@ -0,0 +1,20 @@
+# External (Third Party Container) Tests
+Third Party container tests help verify that the AdoptOpenJDK binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests.


Please change the first part of the sentence to be:
Camel tests are part of the external third-party application tests that help verify that the Adoptium binaries are good...

and update references to AdoptOpenJDK to be Adoptium please.

smlambert · 2021-04-02T13:18:36Z

external/camel/README.md

+8. `make compile` (This fetches test material and compiles it, based on build.xml files in the test directories)
+9. `make _camel_test` (When you defined BUILD_LIST to point to a directory in openjdk-tests/external, then this is a testCaseName from the playlist.xml file within the directory you chose)
+When [running these from the command-line](https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/doc/userGuide.md#local-testing-via-make-targets-on-the-commandline), these tests are grouped under a make target called 'external', so 'make external' would run the entire set of tests found in the openjdk-tests/external directory. This is unadvisable! Limit what you compile and run, BUILD_LIST=external/`<someSubDirectory>`, and TARGET=`<testCaseNameFromSubdirPlaylist>`
+These tests run regularly and results can be found in [TRSS Third Party Application view](https://trss.adoptopenjdk.net/ThirdPartyAppVie).


Missing 'w' at the end of the trss.adoptopenjdk link

smlambert · 2021-04-02T13:22:58Z

external/camel/README.md

@@ -0,0 +1,20 @@
+# External Camel Tests
+Third Party container tests help verify that the Adoptium binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests.


Can I get you to add an extra sentence after this one that says:
Camel tests are functional tests pulled from the camel-quarkus repository.

*please also hyperlink camel-quarkus using the value from github_url in test.properties

sophia-guo · 2021-04-06T14:08:55Z

external/camel/README.md

@@ -0,0 +1,20 @@
+# External Camel Tests
+Third Party container tests help verify that the Adoptium binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests.Camel tests are functional tests pulled from the [camel-quarkus](https://github.com/apache/camel-quarkus.git) repository.


See comment #2451 (comment)

Once this is updated I think the PR is good to go.

sophia-guo · 2021-04-06T19:20:43Z

external/camel/README.md

+7. export required environment variables, BUILD_LIST and EXTRA_DOCKER_ARGS (`export BUILD_LIST=external/camel` and `export EXTRA_DOCKER_ARGS="-v $TEST_JDK_HOME:/opt/java/openjdk"`
+8. `make compile` (This fetches test material and compiles it, based on build.xml files in the test directories)
+9. `make _camel_test` (When you defined BUILD_LIST to point to a directory in openjdk-tests/external, then this is a testCaseName from the playlist.xml file within the directory you chose)
+When [running these from the command-line](https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/doc/userGuide.md#local-testing-via-make-targets-on-the-commandline), these tests are grouped under a make target called 'external', so 'make external' would run the entire set of tests found in the openjdk-tests/external directory. This is unadvisable! Limit what you compile and run, BUILD_LIST=external/`<someSubDirectory>`, and TARGET=`<testCaseNameFromSubdirPlaylist>`


Please add extra blank line before here, so it will be a new paragraph instead of part of number 9.

sophia-guo · 2021-04-06T20:15:51Z

Please also sign off your commit and update your comment #2451 (comment) with Close #2429 , which will automatically close the issue #2229 when this PR is merged.

SAY-droid427 · 2021-04-07T02:27:02Z

@sophia-guo Could you please tell me what is meant by signing off commit?

smlambert · 2021-04-07T02:45:12Z

https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for

Its not strictly required anymore (used to be require by Eclipse Foundation but effective March 30 has been dropped as a requirement).

Signed-off-by: SAY-droid427 <[email protected]>

sophia-guo

LGTM

smlambert

thanks @SAY-droid427 !

Added prep work for camel tests

bec3f84

Added prep work for camel tests

9ac7a1a

smlambert reviewed Apr 1, 2021

View reviewed changes

karianna added this to the April 2021 milestone Apr 1, 2021

karianna added the enhancement label Apr 1, 2021

Changes to the README.md of camel tests

ba619bb

smlambert reviewed Apr 2, 2021

View reviewed changes

Changed README.md for camel-test

fc477a0

sophia-guo reviewed Apr 6, 2021

View reviewed changes

Completed prep work for camel tests

ac2ca50

Signed-off-by: SAY-droid427 <[email protected]>

sophia-guo approved these changes Apr 7, 2021

View reviewed changes

smlambert approved these changes Apr 7, 2021

View reviewed changes

smlambert merged commit 1e05a8f into adoptium:master Apr 7, 2021

SAY-droid427 deleted the prep-camel branch April 29, 2021 02:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Completed prep work for camel tests #2451

Completed prep work for camel tests #2451

SAY-droid427 commented Apr 1, 2021 •

edited

Loading

SAY-droid427 commented Apr 1, 2021

smlambert left a comment

smlambert Apr 1, 2021

SAY-droid427 Apr 2, 2021

smlambert Apr 1, 2021

SAY-droid427 Apr 2, 2021

smlambert Apr 1, 2021

SAY-droid427 Apr 2, 2021

smlambert Apr 1, 2021

SAY-droid427 Apr 2, 2021

smlambert Apr 2, 2021

smlambert Apr 2, 2021

SAY-droid427 Apr 2, 2021

sophia-guo Apr 6, 2021 •

edited

Loading

sophia-guo Apr 6, 2021

sophia-guo commented Apr 6, 2021

SAY-droid427 commented Apr 7, 2021

smlambert commented Apr 7, 2021

sophia-guo left a comment

smlambert left a comment

		@@ -0,0 +1,20 @@
		# External (Third Party Container) Tests
		Third Party container tests help verify that the AdoptOpenJDK binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests.

		@@ -0,0 +1,20 @@
		# External Camel Tests
		Third Party container tests help verify that the Adoptium binaries are good by running a variety of Java applications inside of Docker containers. AdoptOpenJDK/openjdk-tests/Issue #172 lists the applications that we have initially targeted to best exercise the AdoptOpenJDK binaries. For each application, we choose to run a selection of their functional tests.

Completed prep work for camel tests #2451

Completed prep work for camel tests #2451

Conversation

SAY-droid427 commented Apr 1, 2021 • edited Loading

SAY-droid427 commented Apr 1, 2021

smlambert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sophia-guo Apr 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sophia-guo commented Apr 6, 2021

SAY-droid427 commented Apr 7, 2021

smlambert commented Apr 7, 2021

sophia-guo left a comment

Choose a reason for hiding this comment

smlambert left a comment

Choose a reason for hiding this comment

SAY-droid427 commented Apr 1, 2021 •

edited

Loading

sophia-guo Apr 6, 2021 •

edited

Loading