Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Alpine JDK installs #3804

Closed
Haroon-Khel opened this issue Nov 7, 2024 · 2 comments
Closed

Remove redundant Alpine JDK installs #3804

Haroon-Khel opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels

Comments

@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented Nov 7, 2024

Looks like we're installing boot jdks on Alpine using two different roles in our playbooks

In the common role (zulu bianries and nightlies) https://github.com/adoptium/infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/Alpine.yml

and in the adoptopenjdk_install role (only for jdk17 and 21)
https://github.com/adoptium/infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/adoptopenjdk_install/tasks/main.yml

I propose we use the adoptopenjdk_install to install bootjdks and not the common role, as we do with our other platforms. I assume we used the common role to install zulu binaries because there was no other option, so I reckon if these can now be replaced with our own binaries

@Haroon-Khel
Copy link
Contributor Author

#3805 in to stop the adoptopenjdk_install role from installing a non existent GA JDK17 on aarch64 alpine linux

@sxa
Copy link
Member

sxa commented Nov 29, 2024

Closing this as the PR has been closed (Noting that it was in iteration 3 but I can't currently select that as it's closed).

Haroon, I don't think there's any reason to but feel free to re-open if you believe there is more work here.

@sxa sxa closed this as completed Nov 29, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in 2024 4Q Adoptium Plan Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants