Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild_Same_JDK_Reproducibility_Test JDK shows extra debugimage and staticlibs folders #4031

Open
andrew-m-leonard opened this issue Nov 11, 2024 · 1 comment
Assignees
Labels
aarch Issues that affect or relate to the aarch ARCHITECTURE question Issues that are queries about the code base or potential problems that have been spotted testing Issues that enhance or fix our test suites

Comments

@andrew-m-leonard
Copy link
Contributor

Looks like the original JDK is comparing one folder too high?

https://ci.adoptium.net/job/Test_openjdk21_hs_special.system_aarch64_linux/3/console

04:57:05  04:56:57 : Comparing expanded JDKs from jdk-21.0.6+2 with tarJDK/jdk-21.0.6+2 ...
05:08:54  05:08:49 : diff complete - rc=1. Output written to file: reprotest.diff
05:08:54  Only in jdk-21.0.6+2: jdk-21.0.6+2
05:08:54  Only in jdk-21.0.6+2: jdk-21.0.6+2-static-libs
05:08:54  Number of differences: 2
05:08:54  ReproduciblePercent = 99.99 %
05:08:54  Differences found..., logged in: reprotest.diff
@github-actions github-actions bot added aarch Issues that affect or relate to the aarch ARCHITECTURE question Issues that are queries about the code base or potential problems that have been spotted testing Issues that enhance or fix our test suites labels Nov 11, 2024
@andrew-m-leonard
Copy link
Contributor Author

The problem is in fact in the aqa-tests/get.sh getjdkbinary() uncompression of the upstream build artifacts, the extra
jdk-21.0.6+2
jdk-21.0.6+2-static-libs
folders within the j2sdk-image directory are from copying the contents of the debugimage and static-libs archives into the existing j2sdk-image folder created from the jdk archive expansion.
This is happening for two reasons:

  • Temurin debug-image archives have 2 top-level folders rather than the 1 that IBM semeru/openj9 has, and only 1 was being removed
  • The getjdkbinary method does not know about the static-libs folder and as a result copies the folder to within the j2sdk-image folder

@andrew-m-leonard andrew-m-leonard changed the title Rebuild_Same_JDK_Reproducibility_Test JDK comparing wrong directory maybe? Rebuild_Same_JDK_Reproducibility_Test JDK shows extra debugimage and staticlibs folders Nov 13, 2024
@andrew-m-leonard andrew-m-leonard self-assigned this Nov 15, 2024
@andrew-m-leonard andrew-m-leonard moved this to In Progress in 2024 4Q Adoptium Plan Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch Issues that affect or relate to the aarch ARCHITECTURE question Issues that are queries about the code base or potential problems that have been spotted testing Issues that enhance or fix our test suites
Projects
Status: In Progress
Development

No branches or pull requests

1 participant