Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Cookie Path #16

Open
SrgSteak opened this issue Sep 11, 2019 · 1 comment
Open

Setting Cookie Path #16

SrgSteak opened this issue Sep 11, 2019 · 1 comment

Comments

@SrgSteak
Copy link

Is it possible to set the path of a cookie without replacing the cookieHandler? I could make a pullrequest if you want, extending the config with an optional path and adapting the set function.

I like the bundle, really good documentation!

@adrdilauro
Copy link
Owner

Hi @SrgSteak

yes, I think that's a functionality that is indeed missing. Could you open a pull request, and make it configurable from the initialisation of a test?

It should be added as an additional property of AbTestOptions, like domain?:, and then passed it onto generateVersion in the service object.

I'll take care of updating the documentation.

Thanks! Please let me know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants