Skip to content
This repository has been archived by the owner on May 31, 2019. It is now read-only.

Simplify the configuration of newApolloServer #72

Open
darahayes opened this issue Aug 28, 2018 · 0 comments
Open

Simplify the configuration of newApolloServer #72

darahayes opened this issue Aug 28, 2018 · 0 comments
Labels
good first issue Good for newcomers mentor available A core contributor is available to help

Comments

@darahayes
Copy link
Contributor

Description

The newApolloServer function in server/apolloServer.js accepts several configuration arguments and uses them to instantiate a new Apollo Server instance. A lot of these configuration items originate in server/config/index.js but if you take the following lines, There are lots of things being remapped which could have been defined correctly in server/config.js in the first place.

To Do

  • Simplify the configuration such that the newApolloServer function is more concise This can be achieved by moving things like the playground config back into server/config/index.js
  • If possible reduce the arity (number of args) of the newApolloServer function and update any place where it's used.
@darahayes darahayes added good first issue Good for newcomers mentor available A core contributor is available to help labels Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers mentor available A core contributor is available to help
Projects
None yet
Development

No branches or pull requests

1 participant