Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE-REQUEST] Support for Repos using MySQL #193

Open
cybrox opened this issue Jan 19, 2021 · 2 comments
Open

[FEATURE-REQUEST] Support for Repos using MySQL #193

cybrox opened this issue Jan 19, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cybrox
Copy link

cybrox commented Jan 19, 2021

Describe the problem you're proposing to solve
When using Kaffy on a project with a repo using the MySQL database drivers, everything related to schemas breaks, as MySQL does not support ILIKE, only LIKE.

Describe the solution you'd like
Depending on the repository database driver, LIKE (MySQL) or ILIKE (PostgreSQL) should be used.

Describe alternatives you've considered
none

Additional context
I forked kaffy and did the change manually for testing in this commit and it works fine. ILIKE is only used in this one place.

I could submit a PR for a dynamic approach based on the repository driver but I think this would collide with #180. Guess it would be best to complete that PR first :)

@cybrox cybrox added the enhancement New feature or request label Jan 19, 2021
@ykurtbas
Copy link

+1 to this please

@tejpochiraju
Copy link

This prevents usage with SQLite3 as a DB too - admittedly this is a more esoteric crowd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants