New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that it is necessary to wrap popup props with BigNumber #1401

Open

davidyuk opened this issue Jul 27, 2020 · 0 comments

Labels

question refactoring

Member

davidyuk commented Jul 27, 2020

aepp-base/src/popup.js

Lines 45 to 47 in f682fc2

    
           amount: BigNumber(window.modalProps.transaction.amount), 
        
           fee: BigNumber(window.modalProps.transaction.fee), 
        
           minFee: BigNumber(window.modalProps.transaction.minFee),

Why we can't pass BigNumber instances between frames?
Maybe @etharner can recall why we did it in that way?

davidyuk added question refactoring labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment