Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenEXR support #186

Open
flord opened this issue Feb 21, 2019 · 1 comment
Open

OpenEXR support #186

flord opened this issue Feb 21, 2019 · 1 comment

Comments

@flord
Copy link

flord commented Feb 21, 2019

It would be great if PhotoFlow could export images as OpenExr, with pixels brighter than diffuse white having values above 1.0.
Currently, when we export in tiff 32bit float, the entire dynamic range is compressed between 0.0 and 1.0, making the image very dark.
The OpenExr spec defines than an object reflecting 18% of light, exposed correctly, will have a pixel value of 0.18. So very bright pixels like highlights or light sources in the image have values well above 1.0. OpenExr also supports half-float, which saves space.
For example, this DNG image produces this exr image, with pixels in the sky reflection in the glass bowl being above 1.0

@aferrero2707
Copy link
Owner

I have opened an issue here to ask for EXR write support.

However, in PhF the 32-bit floating point TIFF output does not restrict the output range to [0, 1]. Here is an example of your DNG file opened in PhF, saved with a +1EV exposure adjustment: https://filebin.net/zejisryd19wbjxq3
The folder contains both the TIFF file and the .pfi file used to generate it.

And here is a screenshot showing the values of a color sampler placed on the bright reflection:
screen shot 2019-03-05 at 11 52 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants