DrawChar doesn't consider proportional fonts while bounds checking

[jorolf]

Currently, DrawChar doesn't draw chars like "i" or "j", even though they fit, because only the "worst case" character width is considered:

stm32-ssd1306/ssd1306/ssd1306.c

Lines 228 to 235 in d815b74

	// Check remaining space on current line
	if (SSD1306_WIDTH < (SSD1306.CurrentX + Font.width) ||
	SSD1306_HEIGHT < (SSD1306.CurrentY + Font.height))
	{
	// Not enough space on current line
	return 0;
	}

Maybe it could be replaced by code like this:

uint8_t width = Font.char_width ? Font.char_width[ch - 32] : Font.width;

// Check remaining space on current line
if (SSD1306_WIDTH < (SSD1306.CurrentX + width) ||
    SSD1306_HEIGHT < (SSD1306.CurrentY + Font.height))
{
  // Not enough space on current line
  return 0;
}

This could break fonts that are drawing outside of their char width to create overlapping characters. (consider )
Although I'm not sure if those fonts were supported in the first place.

[afiskon]

Yeah, that seems to be a bug introduced in #85 (cc: @kossnikita)

Personally I'm not extremely interested in proportional fonts to be honest, but your pull requests are most welcomed.

[kossnikita]

Got it. I'll check it from my side