diff --git a/CHANGELOG.md b/CHANGELOG.md index 7db7bceeae1..0382cf86225 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ Multiview extension, Spatial computing UIs, Mixed Reality features, Hand manipul ### Bug fixes -- Use renderer.physicallyCorrectLights instead of the now deprecated renderer.useLegacyLights (fix #5293) (@mrx) +- Use renderer.useLegacyLights instead of the deprecated renderer.physicallyCorrectLights in three r150, but keep the physicallyCorrectLights property name for the renderer system for backward compatibility (fix #5293) (@mrx) - Fix `hand-controls` animations (#5300) - Fix outdated link in error message (#5313) (fix #5275) (@kolson25) - Fix visibility of controller in model-viewer example (#5317) (@DougReeder) diff --git a/src/systems/renderer.js b/src/systems/renderer.js index 16b3b261f84..97d2eaba9f7 100644 --- a/src/systems/renderer.js +++ b/src/systems/renderer.js @@ -34,7 +34,9 @@ module.exports.System = registerSystem('renderer', { // This is the rendering engine, such as THREE.js so copy over any persistent properties from the rendering system. var renderer = sceneEl.renderer; - renderer.useLegacyLights = !data.physicallyCorrectLights; + if (!data.physicallyCorrectLights) { + renderer.useLegacyLights = !data.physicallyCorrectLights; + } renderer.toneMapping = THREE[toneMappingName + 'ToneMapping']; THREE.Texture.DEFAULT_ANISOTROPY = data.anisotropy;