Cleanup dead feature #2416
Merged
Cleanup dead feature #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify interface + reduce coupling
alantreadway
reviewed
Sep 9, 2024
| @@ -252,7 +252,7 @@ export class StatusBar | |||
| this.labelGroup.visible = false; | |||
|
|
|||
| this.destroyFns.push( | |||
| ctx.scene.attachNode(this.labelGroup, 'titles'), | |||
| ctx.scene.attachNode(this.labelGroup), | |||
There was a problem hiding this comment.
This was hacked in to fix https://ag-grid.atlassian.net/browse/CRT-394 - can you verify that this case still works after this change?
There was a problem hiding this comment.
Verified and works as expected
Simplify interface + reduce coupling
…/cleanup-statusBar
…/cleanup-statusBar
alantreadway
approved these changes
Sep 10, 2024
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10790873839 |
…moses/cleanup-statusBar
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10791182887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify interface + reduce coupling