AG-12810 Fix legend item CSS bounds #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10791825071 |
olegat
force-pushed
the
AG-12810/fix_legend_item_css_bounds
branch
from
e549ca4
to
214ab77
Compare
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10792096473 |
|
❌ Snapshot update job failed: https://github.com/ag-grid/ag-charts/actions/runs/10792096473 |
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10792169325 |
olegat
force-pushed
the
AG-12810/fix_legend_item_css_bounds
branch
2 times, most recently
from
6834733
to
7f494a6
Compare
olegat
commented
Sep 10, 2024
| return bbox; | ||
| } | ||
| private getLegendItemHitboxProvider(legendItemNode: LegendMarkerLabel): BBoxProvider<BBox> { | ||
| // FIXME: This method is required for the `focusable` property of `createProxyElement`, but the `focusable` property should eventually be removed because it's only required to update the FocusIndicator |
There was a problem hiding this comment.
Note: This will happen when #2418 is ready
olegat
force-pushed
the
AG-12810/fix_legend_item_css_bounds
branch
2 times, most recently
from
a8b4f18
to
badc123
Compare
olegat
force-pushed
the
AG-12810/fix_legend_item_css_bounds
branch
2 times, most recently
from
2867821
to
0483aee
Compare
olegat
force-pushed
the
AG-12810/fix_legend_item_css_bounds
branch
from
0483aee
to
6a3df06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-12810