AG-12887 - Split mouse-down and drag-start events to reduce false drag start on click cases. #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobp100
approved these changes
Sep 17, 2024
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10906274581 |
alantreadway
force-pushed
the
seperate-click-and-drag-events
branch
from
641eb35
to
f84f7b8
Compare
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10920195163 |
jacobp100
reviewed
Sep 18, 2024
alantreadway
changed the title
…g start on click cases.
alantreadway
force-pushed
the
seperate-click-and-drag-events
branch
from
ead843f
to
8504a84
Compare
|
/snapshots |
|
⏱️ Snapshot update job running: https://github.com/ag-grid/ag-charts/actions/runs/10945115305 |
alantreadway
force-pushed
the
seperate-click-and-drag-events
branch
from
1898687
to
0047322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-12887
Stops emission of
drag-startinteraction event type by default onmousedownortouchdown, so that simple click/touch can end with aclickevent, without an intermediate drag-state.As a first pass, simply falls back to emitting
drag-starton firstmousemovewith the mouse button down.