AG-13008, AG-13041 Fix Delete/Escape key deleting the annotation in text-edit mode #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsjroberts
requested changes
Oct 1, 2024
packages/ag-charts-enterprise/src/features/annotations/annotationsStateMachine.ts
Outdated
Show resolved
Hide resolved
lsjroberts
reviewed
Oct 1, 2024
olegat
force-pushed
the
AG-13008/bugfix_delete_textedit
branch
from
c0eb901
to
d572a66
Compare
olegat
force-pushed
the
AG-13008/bugfix_delete_textedit
branch
from
186dc17
to
fceef5c
Compare
olegat
changed the title
I've checked these. ✅ AG-12476 - No regression |
olegat
force-pushed
the
AG-13008/bugfix_delete_textedit
branch
3 times, most recently
from
7b60890
to
b0d8041
Compare
|
Rebased and resolved conflict by dropping the e2e snapshot update to this file: |
… editing text" This reverts commit 5da45e6.
This fixes a regression caused by the removal of the "mouseBlur" feature in KeyNavManager. This is sort of an anti-pattern. Showing the focus after pressing Backspace or Delete on the keyboard is the "correct" behaviour. However, the correct behaviour in this scenario feels flimsy. Rather than restoring the "mouseBlur" feature, we instead create and focus on a temporary so-called "focus mask" which is added above the canvas. The focus mask does not respond to pointer events, and puts the canvas-proxy back into focus whenever any key is pressed. The focus mask is removed once blurred. This mimics the "mouseBlur" functionality that the use to have.
…board" This reverts commit c3477c1.
…n deleting annotation
olegat
force-pushed
the
AG-13008/bugfix_delete_textedit
branch
2 times, most recently
from
3db9d5d
to
8bf7c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13008
https://ag-grid.atlassian.net/browse/AG-13041