Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Expo 51 SDK #383

Open
seanblonien opened this issue Aug 8, 2024 · 4 comments
Open

Support for Expo 51 SDK #383

seanblonien opened this issue Aug 8, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@seanblonien
Copy link

Describe the bug
The expo doctor command throws an error that react-native-health does not support the most up to date version of the @expo/config-plugins package necessary for Expo 51 SDK compatibility.

To Reproduce
Steps to reproduce the behavior:

  1. Run the npx create-expo-app@latest command for a new Expo 51 project
  2. Run cd my-app
  3. Run npx expo install react-native-health
  4. Run npx expo-doctor
  5. See errors

Expected behavior
There be no package compatibility errors when trying to use Expo 51.

Screenshots
image

Smartphone (please complete the following information):

N/A

Additional context
Surprised to see no one else has created an issue for this yet since Expo 51 has been out. But yea, this prevents older Expo versions from upgrading if using this package.

@seanblonien seanblonien added the bug Something isn't working label Aug 8, 2024
@garygcchiu
Copy link

There's a month-old PR that should address this, just need the repo maintainers to take a look 🙏 #381

@arzola
Copy link

arzola commented Aug 13, 2024

how can we contribute to get this done?

@lsandini
Copy link

I see the same thing in my project. It builds fine though and step count retrieval works correctly as well.

@araadt
Copy link

araadt commented Oct 26, 2024

SDK 51 is old news; SDK 52 beta is out and will be released in approx two weeks. How do we get #381 merged?

 $ npx expo-doctor@latest
✔ Check Expo config for common issues
✔ Check package.json for common issues
[…]
✖ Check that native modules use compatible support package versions for installed Expo SDK
✔ Check that packages match versions required by installed Expo SDK

Detailed check results:

Expected package @expo/config-plugins@~8.0.0
Found invalid:
  @expo/[email protected]
  (for more info, run: npm why @expo/config-plugins)
Advice: Upgrade dependencies that are using the invalid package versions.

One or more checks failed, indicating possible issues with the project.

And…

$ npm why @expo/config-plugins
[…]
@expo/[email protected]
node_modules/react-native-health/node_modules/@expo/config-plugins
  @expo/config-plugins@"^7.2.2" from [email protected]
  node_modules/react-native-health
    react-native-health@"^1.19.0" from the root project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants