Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type checking to AgentOS code (auto-run script as part of PR tests/CI) #92

Open
andyk opened this issue Feb 17, 2021 · 2 comments · May be fixed by #308
Open

Add type checking to AgentOS code (auto-run script as part of PR tests/CI) #92

andyk opened this issue Feb 17, 2021 · 2 comments · May be fixed by #308
Labels
core Related to core abstractions and APIs enhancement New feature or request

Comments

@andyk
Copy link
Contributor

andyk commented Feb 17, 2021 •
edited
Loading

Python 3 supports annotating code with type information (see PEP-3107 added in Python 3.0 and PEP-484 added in Python 3.5).

I propose we start using annotations in our code and running a third party type checking library (in the same workflow that we run lint).

Options if we want to do type checking that uses the annotations:

This article summarizes each of these 4 options, but doesn't weigh-in on which to use.

Also note that Pycharm has built-in typechecking.
@andyk andyk added core Related to core abstractions and APIs enhancement New feature or request labels Feb 17, 2021
@andyk andyk mentioned this issue Oct 22, 2021
Merged
@andyk
Copy link
Contributor Author

andyk commented Oct 22, 2021

FYI #182 is related to this Issue

@andyk
Copy link
Contributor Author

andyk commented Mar 1, 2022

Update: We have been using Mypy some.

@andyk andyk changed the title Add type annotations and type checking to AgentOS code Add type checking to AgentOS code (auto-run script as part of PR tests/CI) Mar 1, 2022
@andyk andyk moved this to Todo in Sprint 0.2.0 Mar 4, 2022
@andyk andyk linked a pull request Mar 10, 2022 that will close this issue
Draft
@andyk andyk removed this from Sprint 0.2.0 Mar 22, 2022
@andyk andyk moved this to Todo in Sprint 0.2.2 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Related to core abstractions and APIs enhancement New feature or request
Projects
Sprint 0.2.2
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add script to run mypy and fix errors it finds andyk/agentos
1 participant
@andyk