Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source of diacritic list #2

Open
jodinathan opened this issue Feb 12, 2019 · 4 comments
Open

source of diacritic list #2

jodinathan opened this issue Feb 12, 2019 · 4 comments

Comments

@jodinathan
Copy link

Hi,

Thanks for the lib, will help a lot.

I wonder, where does the map of diacritics used here come from?

@isoos
Copy link
Contributor

isoos commented Feb 12, 2019

I don't recall anymore, probably some public domain data, transformed into this structure. It would be worth to re-do it again, e.g. a quick search revealed this nice list, I wonder what the overlap was.

@jodinathan
Copy link
Author

Found this list on oracle site:
https://docs.oracle.com/cd/E29584_01/webhelp/mdex_basicDev/src/rbdv_chars_mapping.html

when I get some free time I will check the differences

@timashev
Copy link

Sure, the replacement map must be corrected! I noticed that Russian letter 'л' (\u043B) is replaced by Latin letter 'n', which is entirely incorrect! (here: https://github.com/agilord/diacritic/blob/master/lib/src/replacement_map.dart#L159)

@dmitry-kotorov
Copy link

Sure, the replacement map must be corrected! I noticed that Russian letter 'л' (\u043B) is replaced by Latin letter 'n', which is entirely incorrect! (here: https://github.com/agilord/diacritic/blob/master/lib/src/replacement_map.dart#L159)

I've submitted pull request with this correction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants