-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should use uppper case when encoding #6
Comments
Not sure if this would be a breaking change. |
I think that'd be a breaking change now, and for very little benefit. Maybe adding an extra method or a parameter to them? |
I disagree with the "very little benefit" part. By using lower case, the output is non-compliant and therefore incorrect. |
#7 would now break all the codes that rely on the lowercase ids that this code generates. I know at least two apps that use it such way, and their database is case sensitive. If the code is only soft-compliant, I am willing to live with it. |
https://en.wikipedia.org/wiki/Base32#Crockford's_Base32 suggests that the encoded string should only use upper case characters.
The text was updated successfully, but these errors were encountered: