Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pydoctests to proper tests and mock them #18

Open
agonzalezro opened this issue Nov 2, 2017 · 3 comments
Open

Move pydoctests to proper tests and mock them #18

agonzalezro opened this issue Nov 2, 2017 · 3 comments

Comments

@agonzalezro
Copy link
Owner

The README.md has tests but they are not mocked so it makes them kinda useless if you don't have the film it's referring.

Those tests should be mocked and moved away from the README.

@skulltech
Copy link

What framework should we be using for the tests? I recommend pytest, it's currently regarded as one of the most powerful and scalable testing frameworks for Python. I've worked with it too, so I can contribute to the test-suite myself.`

@agonzalezro
Copy link
Owner Author

Hi @skulltech,

I don't have that much of a preference at the moment. I've worked with pytest and nosetests in the past and I don't think that for such a small project would make any difference.

In the other hand, a friend recommended using tox to automate the testing in different versions of python. I think this could be achievable as well depending on the CI platform we use, however, having an option to run tests in different versions locally could be handy.

What are your thoughts?

@skulltech
Copy link

You're right, it won't make much difference which framework we choose. But still, going with pytest would be better as that has better support and all. I will start working on it. Can you assign me on this issue?

And using tox is a good idea, I have heard about it but haven't used it myself. I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants