Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Follow redirects on 405 properly #293

Open
zDyanTB opened this issue Jun 29, 2024 · 4 comments
Open

[Feature] Follow redirects on 405 properly #293

zDyanTB opened this issue Jun 29, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@zDyanTB
Copy link

zDyanTB commented Jun 29, 2024

The range of .is_redirection() does not fit on .is_success(), therefore can't download the file

Url: https://zrn.co/17lite64
Error: `Unrecoverable error while processing https://zrn.co/17lite64 : response status not success - "405 Method Not Allowed"

Not using .is_success() solve this, but might there are a better way

Edit: got confused, said redirection, It's .is_client_error().
Even tough the error is returned, the file can be downloaded

@agourlay
Copy link
Owner

agourlay commented Jul 1, 2024

Thanks for the report 👍

You are right, it looks like some kind of redirection issue.

@agourlay agourlay added the bug Something isn't working label Jul 1, 2024
@agourlay agourlay self-assigned this Jul 1, 2024
@agourlay
Copy link
Owner

agourlay commented Aug 16, 2024

I tried fixing this but it did not look good as redirection on 405 is not a standard thing.

Do you maybe have a clean patch to propose?

@zDyanTB
Copy link
Author

zDyanTB commented Aug 16, 2024

No success either

@agourlay agourlay added the help wanted Extra attention is needed label Aug 17, 2024
@agourlay agourlay changed the title [Bug?] Follow redirects properly [Feature] Follow redirects on 405 properly Aug 17, 2024
@agourlay agourlay added enhancement New feature or request and removed bug Something isn't working labels Aug 17, 2024
@agourlay
Copy link
Owner

I took the liberty to renamed and reclassified the issue now that we have a better understanding.

One of my concern is that it could compromise the code clarity and architecture to implement something a bit exotic in terms of standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants