Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duration of tied notes #17

Open
agourlay opened this issue Dec 8, 2024 · 2 comments
Open

Fix duration of tied notes #17

agourlay opened this issue Dec 8, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@agourlay
Copy link
Owner

agourlay commented Dec 8, 2024

Currently we look only at the immediate next note to check if it is tied.

Actually we should check at all next beats in a current measure and a the next measures.

The goal is to detect precisely a chain of tied notes on a given string to compute correctly the note duration.

@agourlay agourlay added the bug Something isn't working label Dec 8, 2024
@agourlay agourlay changed the title FIx duration of tied notes Fix duration of tied notes Dec 8, 2024
@agourlay
Copy link
Owner Author

agourlay commented Dec 8, 2024

Applies also to the "let ring" effect.

@agourlay
Copy link
Owner Author

Partially fixed with de958c2

Still need to handle longer chains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant