Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: AbstractUART #11

Open
U2654 opened this issue Mar 5, 2021 · 2 comments
Open

Question: AbstractUART #11

U2654 opened this issue Mar 5, 2021 · 2 comments
Assignees
@nmeum

Comments

@U2654
Copy link

U2654 commented Mar 5, 2021

In the constructor of AbstractUART (line 54 of file), you set stop = false. I would suggest to set it the variable false after the treads are started? Or do I miss something?
@Cirromulus
Copy link
Member

Would you like to have stop in an undefined state when threads are running?

@U2654
Copy link
Author

U2654 commented Mar 5, 2021 •
edited
Loading

Sorry, you got me wrong. I did not mean initialising (which indeed should be in the c'tor) but setting its value inside the c'tor to true and after thread initialisation to false.

@Cirromulus Cirromulus reopened this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmeum nmeum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nmeum @Cirromulus @U2654