Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle offline error #71

Closed
wants to merge 13 commits into from
Closed

Handle offline error #71

wants to merge 13 commits into from

Conversation

marvinjude
Copy link

@marvinjude marvinjude commented Apr 4, 2020 •
edited
Loading

Now we can handle the offline error as established in #69 ! 🚀

Also, I abstracted the error handling so generic errors can be handled in a single place

Screen Shot 2020-04-03 at 1 00 56 PM

marvinjude
marvinjude commented Apr 4, 2020
View reviewed changes
Copy link
Author

@marvinjude marvinjude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@marvinjude marvinjude changed the title handles offline error Handle offline error Apr 4, 2020
@marvinjude marvinjude closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinjude @ahmadawais @nezia1