Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make highlights respect word selection mode #742

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Make highlights respect word selection mode #742

wants to merge 9 commits into from

Commits on Sep 29, 2023

  1. Rename is_word_selecting to is_word_selection 

    The word selection state may be relevant after the mouse button has been released
    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    901e12c View commit details
    Browse the repository at this point in the history

  2. Use is_word_selecting to determine word selection mode for highlights 

    Fixes ahrm#741.
    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1139f9e View commit details
    Browse the repository at this point in the history

  3. Remove option exact_highlight_select

    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c6cc1bf View commit details
    Browse the repository at this point in the history

  4. Extend selection start and end positions to coincide with highlight

    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    93b480c View commit details
    Browse the repository at this point in the history

  5. Respect selection boundaries when embedding annotations

    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    af33aaa View commit details
    Browse the repository at this point in the history

  6. Use characters' centres instead of their origin 

    This seems to stabilise selections that involve characters such as full
stops.
    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    189b82a View commit details
    Browse the repository at this point in the history

  7. Add option legacy_word 

    This allows highlights to be expanded to entail entire words when read
from the database or when embedded into PDF files.
    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    ed649a4 View commit details
    Browse the repository at this point in the history

  8. Add expand_highlight command 

    This effectively replaces a selected highlight by one with the original
start and end point modified to match the selection's word boundaries.
    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    225a670 View commit details
    Browse the repository at this point in the history

  9. Add expand_all_highlights command

    @hrdl-github
    hrdl-github committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    bf7fda2 View commit details
    Browse the repository at this point in the history