diff --git a/CHANGELOG.md b/CHANGELOG.md index af346ef3..66ddf5ba 100755 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,15 @@ # Change log +## [1.4.1] - 2023-10-13 +### Added +- Clear buffers before exiting + +### Changed +- + +### Fixed +- + ## [1.4.0] - 2023-05-14 ### Added - Added BIP39 Check for Ledger Stax @@ -8,7 +18,7 @@ - ### Fixed -- Fixed warnings about deprecated functions during build +- Fixed warnings about deprecated functions during build ## [1.3.2] - 2023-05-08 ### Added diff --git a/Makefile b/Makefile index b6a5f960..d40cc515 100755 --- a/Makefile +++ b/Makefile @@ -28,7 +28,7 @@ all: default APPNAME = "Seed Tool" APPVERSION_M = 1 APPVERSION_N = 4 -APPVERSION_P = 0 +APPVERSION_P = 1 APPVERSION = "$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)" APP_LOAD_PARAMS = --appFlags 0x10 $(COMMON_LOAD_PARAMS) --curve secp256k1 --path "" diff --git a/README.md b/README.md index e2deb855..b473aa83 100644 --- a/README.md +++ b/README.md @@ -1,9 +1,16 @@ -# Ledger application that provides some useful seed management utilities +

Seed Tool

-[![Build app-sskr-check](https://github.com/aido/app-sskr-check/actions/workflows/ci-workflow.yml/badge.svg)](https://github.com/aido/app-sskr-check/actions/workflows/ci-workflow.yml) -[![CodeQL](https://github.com/aido/app-sskr-check/actions/workflows/codeql-workflow.yml/badge.svg)](https://github.com/aido/app-sskr-check/actions/workflows/codeql-workflow.yml) -[![Code style check](https://github.com/aido/app-sskr-check/actions/workflows/lint-workflow.yml/badge.svg)](https://github.com/aido/app-sskr-check/actions/workflows/lint-workflow.yml) -[![License](https://img.shields.io/github/license/aido/app-sskr-check)](https://github.com/aido/app-sskr-check/blob/develop/LICENSE) +# Seed Tool: A Ledger application that provides some useful seed management utilities + +[![Build app-seed-tool](https://github.com/aido/app-seed-tool/actions/workflows/ci-workflow.yml/badge.svg)](https://github.com/aido/app-seed-tool/actions/workflows/ci-workflow.yml) +[![CodeQL](https://github.com/aido/app-seed-tool/actions/workflows/codeql-workflow.yml/badge.svg)](https://github.com/aido/app-seed-tool/actions/workflows/codeql-workflow.yml) +[![Code style check](https://github.com/aido/app-seed-tool/actions/workflows/lint-workflow.yml/badge.svg)](https://github.com/aido/app-seed-tool/actions/workflows/lint-workflow.yml) +[![License](https://img.shields.io/github/license/aido/app-seed-tool)](https://github.com/aido/app-seed-tool/blob/develop/LICENSE) + +![nanos](https://img.shields.io/badge/nanos-working-green) +![nanox](https://img.shields.io/badge/nanox-working-green]) +![nanosp](https://img.shields.io/badge/nanosp-working-green) +![stax](https://img.shields.io/badge/stax-in_progress-orange) Use the utilities provided by this Ledger application to check a backed up seed or generate [Shamir's Secret Sharing (SSS)](https://en.wikipedia.org/wiki/Shamir%27s_secret_sharing) for a seed. diff --git a/glyphs/sskr_stax_32px.gif b/glyphs/sskr_stax_32px.gif index 36815d0a..5c6a0218 100644 Binary files a/glyphs/sskr_stax_32px.gif and b/glyphs/sskr_stax_32px.gif differ diff --git a/glyphs/sskr_stax_64px.gif b/glyphs/sskr_stax_64px.gif index af4d15f4..5296be07 100644 Binary files a/glyphs/sskr_stax_64px.gif and b/glyphs/sskr_stax_64px.gif differ diff --git a/src/nano/nanos_enter_phrase.c b/src/nano/nanos_enter_phrase.c index f24e8bad..21ba7def 100644 --- a/src/nano/nanos_enter_phrase.c +++ b/src/nano/nanos_enter_phrase.c @@ -454,8 +454,12 @@ void compare_recovery_phrase(void) { } PRINTF("Root key from device: \n%.*H\n", 64, buffer_device); + bool memcmp_ret = os_secure_memcmp(buffer, buffer_device, 64); + memzero(buffer, 64); + memzero(buffer_device, 64); + // compare both rootkey - if (os_secure_memcmp(buffer, buffer_device, 64)) { + if (memcmp_ret) { memzero(G_bolos_ux_context.words_buffer, G_bolos_ux_context.words_buffer_length); (G_bolos_ux_context.onboarding_type == ONBOARDING_TYPE_BIP39) ? ux_flow_init(0, ux_bip39_nomatch_flow, NULL) diff --git a/src/nano/nanox_enter_phrase.c b/src/nano/nanox_enter_phrase.c index b38f4bd7..02a75b6b 100644 --- a/src/nano/nanox_enter_phrase.c +++ b/src/nano/nanox_enter_phrase.c @@ -493,7 +493,10 @@ static uint8_t compare_recovery_phrase(void) { PRINTF("Root key from device: \n%.*H\n", 64, buffer_device); // compare both rootkey - return os_secure_memcmp(buffer, buffer_device, 64) ? 0 : 1; + uint8_t ret = os_secure_memcmp(buffer, buffer_device, 64) ? 0 : 1; + memzero(buffer, 64); + memzero(buffer_device, 64); + return ret; } void screen_onboarding_restore_word_validate(void) {