Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of Temporal domains #666

Open
maayan25 opened this issue Feb 19, 2025 · 1 comment
Open

Parsing of Temporal domains #666

maayan25 opened this issue Feb 19, 2025 · 1 comment

Comments

@maayan25
Copy link

Describe the bug
When attempting to parse Temporal PDDL files using PDDLReader.parse_problem(), 2 different errors occur.

To Reproduce
Steps to reproduce the behavior (1):

  1. Get office_robot domain and problem
  2. Create a PDDLReader instance, and call its parse_problem() method.
  3. See max recursion error.

Steps to reproduce the behavior (2):

  1. Get IPC pathways domain and problem
  2. Create a PDDLReader instance, and call its parse_problem() method.
  3. See syntax error.

Expected behavior
A parsed temporal problem, as can be received when following the same steps as above, with the temporal IPC Sokoban domain and problem, which contains a "total-time" expression.

Screenshots
For office_robot domain:

File ".../python3.11/site-packages/unified_planning/io/pddl_reader.py", line 1089, in declare_type
    declare_type(father_name, type_declarations[father_name])
  [Previous line repeated 990 more times]
RecursionError: maximum recursion depth exceeded

For Pathways domain:

  File ".../python3.11/site-packages/unified_planning/io/pddl_reader.py", line 539, in _parse_exp
    raise SyntaxError(
SyntaxError: Found invalid expression: total-time. From line: 144, col 47 to line: 144, col 57

Software versions:

  • OS: Ubuntu 24.04
  • Python 3.11, pip 25.0
  • Unified-Planning 1.2.0
  • networkx 3.4.2
  • pyparsing 3.2.1
  • ConfigSpace 1.2.1
@alvalentini
Copy link
Member

Hello @maayan25, the first error should be fixed in #665.

The second error instead is due to the fact that the unified-planning does not support the combination of the minimization of the makespan with other optimization objectives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants