Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding showcase as debugImplementation breaks the release build #396

Open
Kshitij09 opened this issue Oct 7, 2024 · 0 comments
Open

Adding showcase as debugImplementation breaks the release build #396

Kshitij09 opened this issue Oct 7, 2024 · 0 comments

Comments

@Kshitij09
Copy link

Kshitij09 commented Oct 7, 2024

When we add showcase dependency as mentioned in the README

debugImplementation "com.airbnb.android:showkase:1.0.3"

and we would want to assign click action to launch showkase browser activity only in the debug build, current setup breaks the release build as the object Showkase won't be available.

We can either create no-op showcase module for releaseImplementation or split the code between debug & release source sets to make above dependency as implementation. Happy to raise a PR with suitable approach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant