Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG is async, causing babel to crash #18

Closed
SamyPesse opened this issue Jul 19, 2017 · 4 comments · Fixed by #99
Closed

SVG is async, causing babel to crash #18

SamyPesse opened this issue Jul 19, 2017 · 4 comments · Fixed by #99

Comments

@SamyPesse
Copy link

This module makes the assumption that SVGO is sync, it maybe was at some point, but with latest releases ([email protected]), it causes optimize to simply return undefined and babel to crash.
@oomathias
Copy link

Any news regarding this issue?

@kesne
Copy link
Collaborator

kesne commented Nov 6, 2017

This is likely going to be unsolvable short of stripping svgo out of the plugin.

@kesne
Copy link
Collaborator

kesne commented Nov 6, 2017

Or having SVGO expose a sync version of itself.

@lencioni
Copy link
Contributor

lencioni commented Oct 9, 2019

Here is a relevant issue: svg/svgo#1015

@ljharb ljharb mentioned this issue Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Breaking] update svgo to v2; drop node < v10.13 airbnb/babel-plugin-inline-react-svg
4 participants
@lencioni @oomathias @kesne @SamyPesse