Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docs for creating custom interpolation #129

Open
thomaslombart opened this issue Mar 14, 2019 · 3 comments
Open

Missing docs for creating custom interpolation #129

thomaslombart opened this issue Mar 14, 2019 · 3 comments
Labels

Comments

@thomaslombart
Copy link

thomaslombart commented Mar 14, 2019

Hey,

I've been diving into the code source of Polyglot lately and have actually found that we can create a custom interpolation syntax by passing an interpolation property to the Polyglot constructor.

I noticed there are no documentation on how to create our own custom interpolation syntax on your docs and wanted to let you know about it.

@thomaslombart
Copy link
Author

Actually, there is a documentation on the repo's README file but not on Airbnb's engineering website (https://airbnb.io/polyglot.js/).

@ljharb
Copy link
Collaborator

ljharb commented Jun 21, 2019

Docs have been updated.

@ljharb ljharb closed this as completed Jun 21, 2019
@tomsabin
Copy link

tomsabin commented Aug 8, 2019

@ljharb looks like there's some rendering issues on the airbnb.io/polyglot.js site:

GitHub README airbnb.io/polyglot.js
Screenshot 2019-08-08 at 17 23 00 Screenshot 2019-08-08 at 17 22 49

notice that on airbnb.io there is only the single character ' instead of '{{'

@ljharb ljharb reopened this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants