Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing "special" meaning of symbols page #316

Open
jaridmargolin opened this issue May 7, 2018 · 1 comment
Open

Investigate removing "special" meaning of symbols page #316

jaridmargolin opened this issue May 7, 2018 · 1 comment

Comments

@jaridmargolin
Copy link
Collaborator

There are several branches of logic that place a special meaning on the "Symbols Page". It is worth investigating if we can remove these branches in order to simplify internals and provide a more consistent and expected interface.


Discussed during review of #297

mathieudutour: I'm wondering if we really need to forbid rendering into the Symbols page. There is nothing special about in Sketch except being the default location where symbols are going but they can be created in any page and you can any type of layers to the Symbols page

jaridmargolin: I more or less agree with your sentiment, but I think that is a larger question that would need to be addressed in a standalone task. The current implementation of symbols makes a few assumptions about the Symbols page.


cc @mathieudutour

@mathieudutour
Copy link
Collaborator

mathieudutour commented Jun 1, 2018

I'm wondering if we could provide a SymbolMaster component that creates a symbol from its child and could be rendered anywhere. Additionally, we could have a SymbolInstance component with a symbolMasterName prop. We would need to make sure that the symbol master is rendered before the instance tho. But if we manage to do it, we can remove the entire makeSymbol/injectSymbols hack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants