Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Page.Container component #342

Open
jaridmargolin opened this issue May 30, 2018 · 2 comments · May be fixed by #500
Open

Introduce Page.Container component #342

jaridmargolin opened this issue May 30, 2018 · 2 comments · May be fixed by #500

Comments

@jaridmargolin
Copy link
Collaborator

Right now the Page component acts a flex container, allowing to render Artboard's and SymbolMaster's in either a column or a row.

I'd like however to have unlimited flexibility rendering Pages by composing Flex components. By having some sort of arbitrary Flex container, I could layout items on a Page in complex grids if necessary.

This would require us introducing a new Component that can be utilized to compute Yoga layout, but doesn't actually result in any backed rendering.

@mathieudutour - I know this goes against some of your comments in #291, but I'm not sure how else to achieve this.

note: it doesn't need to be called Flex.

@mathieudutour
Copy link
Collaborator

mathieudutour commented May 30, 2018

Yes I can see the use case. Maybe we could make it super clear and have it as a component exposed on the Page component like Page.Container or something. That way we don't create a new component per se so it might be easier to understand where and how to use it.

What do you think?

@jaridmargolin
Copy link
Collaborator Author

Ahhh, yes. I like the idea of Page.Container.... I will open a PR :) Thanks for the suggestion.

@jaridmargolin jaridmargolin changed the title Introduce Flex component Introduce Page.Container component Jun 10, 2018
macintoshhelper added a commit to macintoshhelper/react-sketchapp that referenced this issue Apr 18, 2020
@macintoshhelper macintoshhelper linked a pull request Apr 18, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants