Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(annotation): can't restrict EditableAnnotation to desired x/y bounds #1541

Open
gracelauren opened this issue Jul 14, 2022 · 2 comments
Open

feature(annotation): can't restrict EditableAnnotation to desired x/y bounds #1541

gracelauren opened this issue Jul 14, 2022 · 2 comments
Labels
🚀enhancement 👋 help wanted @visx/annotation

Comments

@gracelauren
Copy link

You can drag the editable annotation outside of the graph

https://codesandbox.io/s/pricing-chart-proto-forked-b4nlpq
image

image
@williaster
Copy link
Collaborator

currently we don't expose the @visx/drag useDrag options to restrict the coordinates to which annotation subjects/labels can be moved to.

if you want to submit a PR to expose this I'm happy to review.

@williaster williaster changed the title EditableAnnotation outside of graph feature(annotation): can't restrict EditableAnnotation to desired x/y bounds Jul 14, 2022
@rajankonar rajankonar mentioned this issue Jul 13, 2024
Open
@rajankonar
Copy link

Hi @williaster Hope above PR solves the issue. #1858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀enhancement 👋 help wanted @visx/annotation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@williaster @gracelauren @rajankonar