patch verison bump for aws-java-sdk #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Closing to fix my branch naming based on the contributing guidelines. New PR here: #354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This GitHub Issue for the aws java sdk discusses how version 1.12.746 of the sdk is the first version that supports the EKS pod identity add-on. Seeing how airbyte is moving to kubernetes deployment of it's open source platform, it makes sense for this sdk version to be updated to support EKS pod identity deployments.
How
Simply updating the aws-java-sdk dependency to be on version
1.12.746will enable support for EKS pod identity to work.This page shows which AWS SDKs and versions support EKS pod identity.
Recommended reading order
Can this PR be safely reverted and rolled back?