Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch version bump for aws-java-sdk #354

Conversation

GideonStowell
Copy link

What

This GitHub Issue for the aws java sdk discusses how version 1.12.746 of the sdk is the first version that supports the EKS pod identity add-on. Seeing how airbyte is moving to kubernetes deployment of it's open source platform, it makes sense for this sdk version to be updated to support EKS pod identity deployments.

How

Simply updating the aws-java-sdk dependency to be on version 1.12.746 will enable support for EKS pod identity to work.
This page shows which AWS SDKs and versions support EKS pod identity.

Recommended reading order

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@GideonStowell GideonStowell force-pushed the GideonStowell/update-java-aws-sdk-version branch 2 times, most recently from b6b5ce9 to 55248a6 Compare August 23, 2024 20:03
@bgroff bgroff requested a review from malikdiarra August 27, 2024 01:29
@GideonStowell GideonStowell force-pushed the GideonStowell/update-java-aws-sdk-version branch from 55248a6 to a300bd5 Compare August 28, 2024 04:06
@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ malikdiarra
✅ GideonStowell
❌ davinchia
You have signed the CLA already but the status is still pending? Let us recheck it.

@airbytehq airbytehq deleted a comment from github-actions bot Aug 28, 2024
@airbytehq airbytehq deleted a comment from github-actions bot Aug 28, 2024
@airbytehq airbytehq deleted a comment from github-actions bot Aug 28, 2024
@malikdiarra
Copy link
Contributor

/create-oss-pr

Copy link
Contributor

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

@davinchia
Copy link
Contributor

/create-oss-pr

Copy link
Contributor

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

@GideonStowell
Copy link
Author

After viewing the conflicts I see that @davinchia merged a commit last week that bumped up the Java AWS SDK to a version that should support EKS Pod Identity authentication in k8s pods.
I will test this and report back.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

@GideonStowell
Copy link
Author

I was able to test out using eks pod identity and service accounts to give permissions to the airbyte pods. Simply updated the image tags to 0.64.2+ and it pulled the newer images.
Closing.

@GideonStowell GideonStowell deleted the GideonStowell/update-java-aws-sdk-version branch September 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants