Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Christo/finalize cdk sdm publish flow #76

Closed
wants to merge 34 commits into from
Closed

Christo/finalize cdk sdm publish flow #76

wants to merge 34 commits into from

Conversation

ChristoGrab
Copy link
Collaborator

WAT WAT

aaronsteers
aaronsteers reviewed Nov 19, 2024
View reviewed changes
.github/workflows/pypi_publish.yml Outdated
Comment on lines 53 to 60
- name: Attach Wheel to GitHub Release
uses: svenstaro/upload-release-action@v2
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
file: dist/*.whl
tag: ${{ github.ref }}
tag: ${{ env.VERSION }}
overwrite: true
file_glob: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristoGrab - This step will only work with release tag events.

You can add an "if" condition like if: startsWith(github.ref, 'refs/tags/v') to skip it for workflow dispatch.

The reason is that it's job is to attach the wheel to the release (not strictly necessary anyway). If using the VERSION env var, the "tag" format will probably need to be reconstructed: refs/tags/v${VERSION}.

@ChristoGrab
Copy link
Collaborator Author

Closing in favour of a fresh PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristoGrab @aaronsteers