-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After CDK Publish, Auto-Generate PR to Bump CDK in Connector Builder Repo #79
Comments
This was referenced Nov 20, 2024
There are 2 separate things at play here
|
octavia-squidington-iii
pushed a commit
to airbytehq/airbyte-platform
that referenced
this issue
Dec 3, 2024
Update the platform's CDK version to v6.7.2. This PR was manually created by running the commands that used to run as part of a github action, modified slightly to hardcode the new version and work when running locally on a mac (i.e. adding `''` after `-i` in `sed`, see [this SO post](https://stackoverflow.com/a/42667816) for why): ``` PREVIOUS_VERSION=$(cat oss/airbyte-connector-builder-resources/CDK_VERSION) NEW_VERSION=6.7.2 sed -i '' "s/${PREVIOUS_VERSION}/${NEW_VERSION}/g" oss/airbyte-connector-builder-server/Dockerfile sed -i '' "s/${PREVIOUS_VERSION}/${NEW_VERSION}/g" cloud/airbyte-connector-builder-server-wrapped/Dockerfile sed -i '' "s/airbyte-cdk==${PREVIOUS_VERSION}/airbyte-cdk==${NEW_VERSION}/g" oss/airbyte-connector-builder-server/requirements.in echo ${NEW_VERSION} > oss/airbyte-connector-builder-resources/CDK_VERSION cd oss/airbyte-connector-builder-server pip install pip-tools pip-compile --upgrade ``` This will be automated again soon; see [this issue](airbytehq/airbyte-python-cdk#79)
Closing as complete. Was shipped a little while ago... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example PR here:
Created from code here:
https://github.com/airbytehq/airbyte/pull/48470/files#diff-3249d7445228172f9b36422eb8685d1b2def3c8953331f8d393756c64d9be7e9L285-L388
The text was updated successfully, but these errors were encountered: