Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 50397: destination-iceberg: add oauth2 scope to REST catalog config #50939

Conversation

MChamberlin
Copy link

@MChamberlin MChamberlin commented Jan 4, 2025

What

Fixes 50397 (destination-iceberg): adds OAuth2 scope parameter to Iceberg REST catalog config.

It is often necessary to provide an OAuth2 scope along with client credentials for an Iceberg REST Catalog connection, particularly for the Apache Polaris REST catalog. The scope parameter is supported by the current iceberg-spark-runtime version, but was not exposed in the Airbyte destination configuration.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@MChamberlin MChamberlin requested a review from a team as a code owner January 4, 2025 18:51
Copy link

vercel bot commented Jan 4, 2025

@MChamberlin is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2025

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 4, 2025
@MChamberlin MChamberlin changed the title destination-iceberg: add oauth2 scope to REST catalog config Fixes 50397: destination-iceberg: add oauth2 scope to REST catalog config Jan 4, 2025
@marcosmarxm
Copy link
Member

@MChamberlin can you sign the CLA?

@edgao
Copy link
Contributor

edgao commented Jan 6, 2025

hey, sorry, I'm actually going to close this - we've actually been working on a new version of this connector :( So I would consider this part of the codebase frozen.

The new connector is in the destination-iceberg-v2 directory, and doesn't have support for the REST catalog yet (though it's definitely on our radar as being a thing we want to add). If you want to take a stab at adding REST support + this oauth scope feature, I'd be happy to review that though!

(also, feel free to spectate the beta test #50404 )

@edgao edgao closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[destination-iceberg] support OAuth2 scope parameter in Iceberg REST catalog connection
5 participants