-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BCH support #21
Comments
Yes, integrating BCH would probably be very straight forward. The reason we are hesitant to include bitcoin derivatives is because it opens a new attack surface where users can be tricked into signing a valid transaction that is masked as another currency. In this example, a BTC transaction could be displayed as a BCH transaction. A vulnerability in many HW wallets was discovered a while ago that exploited this. It looks like BCH is not affected by this, but we'll still have to do some research to make sure we don't miss anything: https://donjon.ledger.com/lsb/014/ Nonetheless, we will discuss this internally. |
Yeah, better to be safe than sorry. Thanks for such a quick response! |
You're welcome. I will update this ticket when we have news. |
Hey there, any decisions made? :) |
It should be fairly easy as it is almost the same as Bitcoin BTC
The text was updated successfully, but these errors were encountered: