Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

Config bundler NPE when missing server settings #11

Open
electrum opened this issue Jan 25, 2013 · 0 comments
Open

Config bundler NPE when missing server settings #11

electrum opened this issue Jan 25, 2013 · 0 comments

Comments

@electrum
Copy link
Member

An NPE occurs if the settings file doesn't have a <server> entry with a matching <id>. The result of settings.getServer(...) needs to be checked for null with an appropriate user error thrown.

Exception in thread "main" java.lang.NullPointerException
at io.airlift.airship.configbundler.Maven.makeRemoteRepository(Maven.java:102)
at io.airlift.airship.configbundler.Maven.<init>(Maven.java:90)
at io.airlift.airship.configbundler.SnapshotCommand.call(SnapshotCommand.java:60)
at io.airlift.airship.configbundler.SnapshotCommand.call(SnapshotCommand.java:21)
at io.airlift.airship.configbundler.ConfigBundler.main(ConfigBundler.java:31)

Additionally, the constructor for that class has the repository info parameters as @Nullable when they should not be. The validateRepositoryMetadata method should validate them as not null.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant