Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of logical fields in R #782

Open
javh opened this issue Apr 8, 2024 · 0 comments
Open

Validation of logical fields in R #782

javh opened this issue Apr 8, 2024 · 0 comments
Assignees
Labels
R library R reference library for AIRR standards
Milestone

Comments

@javh
Copy link
Contributor

javh commented Apr 8, 2024

I merged in #731, which allows for NA as valid values in a logical column - consistent with the python package and the R rules for logical values.

However, this broke the logical validation routines because readr::read_tsv converts invalid values (not T, F, NA) to NA if a column is set to a logical type. Meaning, the validation routines won't see the invalid value, because validation happens on the loaded data frame. We'd have to let the whole column be set to a character type to keep the invalid values, which breaks other things.

I change the R unit tests to let this pass so master isn't broken. I'm making this issue to remind me to come back and try to figure out a proper fix later.

@javh javh added this to the AIRR 2.0 milestone Apr 8, 2024
@javh javh self-assigned this Apr 8, 2024
@github-project-automation github-project-automation bot moved this to To do in R Package Aug 28, 2024
@javh javh added the R library R reference library for AIRR standards label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R library R reference library for AIRR standards
Projects
Status: To do
Development

No branches or pull requests

1 participant