You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I merged in #731, which allows for NA as valid values in a logical column - consistent with the python package and the R rules for logical values.
However, this broke the logical validation routines because readr::read_tsv converts invalid values (not T, F, NA) to NA if a column is set to a logical type. Meaning, the validation routines won't see the invalid value, because validation happens on the loaded data frame. We'd have to let the whole column be set to a character type to keep the invalid values, which breaks other things.
I change the R unit tests to let this pass so master isn't broken. I'm making this issue to remind me to come back and try to figure out a proper fix later.
The text was updated successfully, but these errors were encountered:
I merged in #731, which allows for
NA
as valid values in a logical column - consistent with the python package and the R rules for logical values.However, this broke the logical validation routines because
readr::read_tsv
converts invalid values (notT
,F
,NA
) toNA
if a column is set to a logical type. Meaning, the validation routines won't see the invalid value, because validation happens on the loaded data frame. We'd have to let the whole column be set to a character type to keep the invalid values, which breaks other things.I change the R unit tests to let this pass so master isn't broken. I'm making this issue to remind me to come back and try to figure out a proper fix later.
The text was updated successfully, but these errors were encountered: