Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorisation: add protocol for DB access as implement Prisma and In-memory versions #9

Closed
13 tasks done
davorrunje opened this issue Jul 29, 2024 · 1 comment
Closed
13 tasks done

Refactorisation: add protocol for DB access as implement Prisma and In-memory versions #9

davorrunje opened this issue Jul 29, 2024 · 1 comment
Assignees
@kumaranvpl

Comments

@davorrunje
Copy link
Contributor

davorrunje commented Jul 29, 2024 •
edited by kumaranvpl
Loading

  • Sync -> get default, set_default
  • Gap between method in base
  • Rename to BackendDBProtocol and FrontendDBProtocol
  • Separate tests for prisma.py
  • Separate implementation of in memory
  • Separate tests for inmemory
  • Use inmemory in tests
  • class defaultdb
  • Remove typeadapter
  • fix agents/base.py
  • Move lifespan
  • Use Union[str, UUID]
  • Fix exception raising
@kumaranvpl kumaranvpl mentioned this issue Aug 14, 2024
Merged
13 tasks
@kumaranvpl
Copy link
Collaborator

Fixed at #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaranvpl kumaranvpl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumaranvpl @davorrunje