Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-poptrox="ignore" breaks the last item in the gallery #26

Open
michaelbiggers opened this issue Apr 28, 2015 · 6 comments
Open

data-poptrox="ignore" breaks the last item in the gallery #26

michaelbiggers opened this issue Apr 28, 2015 · 6 comments
Labels
bug

Comments

@michaelbiggers
Copy link

First, great lightbox!

Whenever an anchor is added with the ignore date attribute, clicking the final item in the gallery logs a javascript error and hangs the page.
pwojnowski pushed a commit to pwojnowski/jquery.poptrox that referenced this issue May 1, 2015
Fix for ajlkn#26 - indexing of queued items
46a1279 
The problem is that marking anchor as ignored results in not adding it
to the images queue, hence the queue is shorter than total number of
images. The initial processing goes through images and creates a
function that trigger opening an image by its initial index, but the
index is different in the queue due to ignored images.
pwojnowski pushed a commit to pwojnowski/jquery.poptrox that referenced this issue May 8, 2015
Fix for ajlkn#26 - indexing of queued items
29f6fa9
pwojnowski pushed a commit to pwojnowski/jquery.poptrox that referenced this issue May 9, 2015
Fix for ajlkn#26 - indexing of queued items
e3fdfa5
@ajlkn
Copy link
Owner

ajlkn commented Nov 18, 2015

Will look into this. Thanks.

@ajlkn ajlkn added the bug label Oct 23, 2016
@neesarg-yb
Copy link

Did you solve this bug?

I am also having same loading issue when there are "ignore" tags in between the collection of images and YouTube links.

If you have tried, please give me a lead so that I can work on it.

@camnicklaus
Copy link

I'm having the same issue

@pwojnowski
Copy link

@ajlkn why don't you just merge PR #27 ?

@crapazilla
Copy link

I have the same issue. Any fix available?

@camnicklaus
Copy link

@crapazilla
pwojnowski solution worked for me. grab the repo from his github page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pwojnowski @ajlkn @michaelbiggers @crapazilla @camnicklaus @neesarg-yb