Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch bookmark icons automatically... #1338

Closed
Jaxel opened this issue Aug 29, 2023 · 4 comments
Closed

Fetch bookmark icons automatically... #1338

Jaxel opened this issue Aug 29, 2023 · 4 comments
Labels
✨ Feature A feature you'd like to be added

Comments

@Jaxel
Copy link

Jaxel commented Aug 29, 2023

Description

When you input a URL for a bookmark, you have to manually assign an image for the icon.

It would be convenient if at first, the system fetched the source of that URL and looked for <link rel="icon" or <link rel="apple-touch-icon" to find the default icon for that bookmark. If no icons are find, try to fetch /favicon.ico automatically.

Priority

Low (Nice-to-have)

@Jaxel Jaxel added the ✨ Feature A feature you'd like to be added label Aug 29, 2023
@ajnart
Copy link
Owner

ajnart commented Sep 1, 2023

I’m not exactly sure how we can do that. But I believe we could implement that. Although the favicons are usually 16x16 so it would look terrible when increased to your app icon.

Can you send me a direct example of that ?
Like example page, and header data linking to the app’s icon.
Also maybe some websites will have relative paths idk how to handle that (icon = ./public/icon.ico)

@Jaxel
Copy link
Author

Jaxel commented Sep 1, 2023

That's why I said favicons used be used as a fallback; only if an icon or apple-touch-icon are not found.

You can easily cURL the bookmarked page, and then run a regex for the icons.

@manuel-rw
Copy link
Collaborator

Related with #1694

@Meierschlumpf
Copy link
Collaborator

Moved to homarr-labs/homarr#2480

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Homarr Kanban Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature A feature you'd like to be added
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants