label support

[zedoul]

Hi such a nice package. Any chance you are going to add a "label" support as it is in JSON stat offical example? Adding label attribute, which is the same level as index attribute, would be helpful.

Just to make things clear: here is one example for label attribute (https://json-stat.org/samples/oecd.json)

"area" : {
		"category" : {
			"index" : {
				"AU" : 0,
				"AT" : 1,
                                    ...
                            },
			"label" : {
				"AU" : "Australia",
				"AT" : "Austria",
                                    ...
                            },
 }

And here is the result of rjstat:

"category":{"index":["Australia","Austria",...]}

which has labels data in index attribute, not separated.

I wonder this difference between official one and outcome of rjstat, is something you intended to do or something that needs to be improved. The official site (https://json-stat.org/format/#index) states that the first one is recommended --- "For efficiency reasons (see Arrays vs. Objects), an object that attaches a position to every ID can also be used (this is currently the recommended format)."

If you have no plan to introduce that feature yet, then do you have any idea of how to achieve that? I may implement that feature, but I know not the whole picture of this package so it would be great to know some direction.

Thank you.

[ajschumacher]

Hi @zedoul! Do you mean support as is currently described like this in README.md?

# You can also read in using the typically terser IDs rather than labels.
results <- fromJSONstat(readLines(oecd.canada.url), naming="id")

The key part there is the naming="id".

Let me know if that works for you, or whether you mean something else.

(Also, I haven't used rjstat in a while; @hmalmedal may have a better understanding of this.)

[zedoul]

Thank you for your response :D

Do you mean support as is currently described like this in README.md?

No.

What I asked was to create label attribute by using toJSONstat function like

AS-IS

> cat(toJSONstat(fromJSONstat(readLines(oecd.canada.url))))
"category":{"index":["2003","2004","2005","2006","2007","2008","2009","2010","2011","2012","2013","2014"]}

TO-BE

> cat(toJSONstat(fromJSONstat(readLines(oecd.canada.url))))
"category":{"index":["2003":0,"2004":1,...], "label":["2003":"2003", "2004":"2004",...]}

I know this example is bad xD, this is exactly the same as in the official website (https://json-stat.org/format/#label). But, for some case, I need label attribute.

The point is, I hope to add label attribute by using toJSONstat function, and it is not related with fromJSONstat.

[ajschumacher]

Ah! Okay, I think I see. Seems like a good idea!

[ajschumacher]

@zedoul created a package that (I guess?) implements this idea and "implement[s a] tidyverse-like way of describing JSON-stat description not the rjstat way". I haven't checked it out, but maybe it's great!

https://github.com/zedoul/jsonstat

[badosa]

I don't see the point of having two similar (but different) JSON-stat packages for R. Can @zedoul's new functionality be included in rjstat?

[ajschumacher]

I think it could be, but I'm not totally sure what the changes are; I'd love to see a PR.