Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay app rendering till settings are loaded #600

Open
ygrishajev opened this issue Dec 30, 2024 · 0 comments
Open

Delay app rendering till settings are loaded #600

ygrishajev opened this issue Dec 30, 2024 · 0 comments

Comments

@ygrishajev
Copy link
Contributor

ygrishajev commented Dec 30, 2024

We use quite some tweaks to make sure we get our settings available. For instance all the chain data fetched via react query hooks depends on url got from settings. This causes checks in every such hook with weird logic. These hooks are used on every page and cause loading states anyway. So we need to make sure app doesn't load till we have all the data for the app to function properly.

Acceptance criteria:

  • make sure the app rendering is delayed till settings are fetched
  • app should be in the loading state meanwhile
  • refactor settings to make sure interface guarantees required props presence
  • remove settings values checks across the app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant