Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create more tests #2

Open
akbiggs opened this issue Jun 3, 2018 · 1 comment
Open

Create more tests #2

akbiggs opened this issue Jun 3, 2018 · 1 comment
Assignees
@akbiggs

Comments

@akbiggs
Copy link
Owner

akbiggs commented Jun 3, 2018

It's starting to get annoying to refactor the scripts because of the amount of manual testing that needs to be done. We should create tests for these scripts (e.g. using the Challonge API to create tournaments, run scripts, verify that the tournament was updated correctly, and then delete the tournament to clean up afterwards).

This will require some refactoring to the scripts to allow test data / mocking to be introduced nicely.
@akbiggs akbiggs self-assigned this Jun 8, 2018
@akbiggs
Copy link
Owner Author

akbiggs commented Jun 8, 2018

I decided to just make the tests verify the script output directly using Bats, started adding stuff under the tests directory.

@akbiggs akbiggs changed the title Create tests Create more tests Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akbiggs akbiggs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akbiggs