Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window resize #90

Open
brosky opened this issue Apr 8, 2019 · 4 comments
Open

Window resize #90

brosky opened this issue Apr 8, 2019 · 4 comments

Comments

@brosky
Copy link

brosky commented Apr 8, 2019

Steps to reproduce:

  1. Start a session with a window at a random size, login to a terminal via Aker
  2. Resizing the window will cause the terminal boundaries to be fixed - even if you make the window larger, the terminal will stay at the login-time-coordinates.
    If I log-out / log-in to that box, the window size is ok, according to the new dimensions.
@anazmy
Copy link
Contributor

anazmy commented Apr 15, 2019

What ssh client do you use?
What is your terminal environment variable, "env|grep -i term" ?
Can you attach a screenshot of the messed screen please?

@brosky
Copy link
Author

brosky commented Apr 16, 2019

I see this in logs:

Apr 16 18:32:17 sshgw-cj Aker: SSHClient ERROR - global name 'get_console_dimensions' is not defined

I'll attach later a screenshot too.
I've recorded with asciinema a sample wrong wrapping, but on the screen looks wrong and the recording is fine :)

@anazmy
Copy link
Contributor

anazmy commented Apr 20, 2019

Hmm, interesting. Please share all data above to check.

@EoleDev
Copy link
Contributor

EoleDev commented Mar 1, 2021

Hi @anazmy,
I had the same issue with the terminal resize on i3.
It seems you are using a signal (SIGWINCH) to catch a window resize.
It seems this signal is not always sent, or working.
As I saw on this example : https://github.com/sirosen/paramiko-shell/blob/master/interactive_shell.py
you could check the terminal size on each iteration without much over cost (it seems).
I implemented it on my aker version and all seems to work well since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants